Add a new flag for enabling/disabling AdoptedResource reconciler #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new feature flag `enable-adopted-resource-reconciler` to allow enabling or disabling the `AdoptedResource` reconciler. The reconciler is now only started if this flag is set to true. This lays the groundwork for a new way to adopt resources, via an adopted resource annotation instead of using the `AdoptedResource` custom resource. This change provides more flexibility in choosing whether users want to use the AdoptedResource CRD or the adoption annotation to adopt resources. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
a-hilaly
commented
Mar 25, 2024
Comment on lines
+131
to
+135
| flag.BoolVar( | ||
| &cfg.EnableAdoptedResourceReconciler, flagEnableAdoptedResourceReconciler, | ||
| true, | ||
| "Enable the AdoptedResource reconciler.", | ||
| ) |
There was a problem hiding this comment.
Keeping the default to true for now. We should start thinking about deprecation and removal dates, once the adoption via annotation is supported
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jlbutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new feature flag
enable-adopted-resource-reconcilertoallow enabling or disabling the
AdoptedResourcereconciler. The reconcileris now only started if this flag is set to true.
This lays the groundwork for a new way to adopt resources, via an adopted
resource annotation instead of using the
AdoptedResourcecustom resource.This change provides more flexibility in choosing whether users want to
use the AdoptedResource CRD or the adoption annotation to adopt
resources.
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.