Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature (schema) - Support resource schemas as a methodology to validate resource configuration #2325

Closed

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Aug 11, 2022

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the feature/convert/resourcespec branch 4 times, most recently from 2c60e1e to 93da3ae Compare August 12, 2022 21:06
@kddejong kddejong force-pushed the feature/convert/resourcespec branch 15 times, most recently from 9d68a0e to d3f8b42 Compare October 11, 2022 17:43
@kddejong kddejong mentioned this pull request Oct 28, 2022
2 tasks
@kddejong kddejong force-pushed the feature/convert/resourcespec branch 5 times, most recently from aed0dac to 9094fab Compare November 23, 2022 04:10
@kddejong kddejong marked this pull request as ready for review November 23, 2022 04:13
@kddejong kddejong force-pushed the feature/convert/resourcespec branch 3 times, most recently from 7127543 to 6b60b6a Compare November 23, 2022 04:41
@kddejong
Copy link
Contributor Author

Lots of changes in the final change. Look at 6b60b6a for all the changes that aren't associated to downloading the resource type specs

@kddejong kddejong force-pushed the feature/convert/resourcespec branch 3 times, most recently from bcec078 to 8db8e81 Compare November 23, 2022 21:50
@kddejong kddejong changed the title Support resource schemas as the primary methodology to validate resource configuration feature (schema) - Support resource schemas as a methodology to validate resource configuration Nov 23, 2022
@kddejong kddejong force-pushed the feature/convert/resourcespec branch 4 times, most recently from afe811f to 5ac3c94 Compare November 28, 2022 16:00
@kddejong kddejong force-pushed the feature/convert/resourcespec branch 3 times, most recently from 5cd9902 to 4ac3a45 Compare December 7, 2022 07:04
@PatMyron
Copy link
Contributor

Haven't read the code, but high-level thoughts:

  1. Make sense to have rollout steps? (new version behind flag, default to new version and old version available with flag, then remove old version)

  2. % resource types migrated to registry to switch primary method from specs to schemas? Registry's currently 664/997 resource types

  3. re-hash of Decrease installation size #2455 discussion where these unzipped schemas are as large as the specifications, should we even unzip them before checking them in? Seems unreviewable either way now when there are tens of thousands of schema files

# large region: us-east-1
6.6M	CloudformationSchema/
1.1M	CloudformationSchema.zip
# small region: eu-south-1
3.8M	CloudformationSchema/
616K	CloudformationSchema.zip

@kddejong
Copy link
Contributor Author

@PatMyron

Haven't read the code, but high-level thoughts:

1. Make sense to have rollout steps? (new version behind flag, default to new version and old version available with flag, then remove old version)

I'm debating doing a beta version under the v1.x.x. namespace to start. This one has been hard to hide under a feature flag because we have been so dependent on the structure of the specs.

2. % resource types migrated to registry to switch primary method from specs to schemas? Registry's currently 664/997 resource types

3. re-hash of [Decrease installation size #2455](https://github.com/aws-cloudformation/cfn-lint/issues/2455) discussion where these unzipped schemas are as large as the specifications, should we even unzip them before checking them in? Seems unreviewable either way now when there are tens of thousands of schema files

Open to ideas here. The way it is now is that files are soft linked if they are duplicate to the files in us-east-1. I believe this installation size was actually smaller but I would have to double check that.

# large region: us-east-1
6.6M	CloudformationSchema/
1.1M	CloudformationSchema.zip
# small region: eu-south-1
3.8M	CloudformationSchema/
616K	CloudformationSchema.zip

@kddejong
Copy link
Contributor Author

Replacing this PR with #2583

@kddejong kddejong closed this Feb 12, 2023
@kddejong kddejong deleted the feature/convert/resourcespec branch June 27, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants