Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default configuration for rule E3012 to not be strict #2103

Merged

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Change the default configuration of rule E3012 to not be strict

There are a few reasons for this change:

  1. All values are passed in to the code that does the provisioning using strings
    https://github.com/aws-cloudformation/cloudformation-cli-python-plugin/blob/master/src/cloudformation_cli_python_lib/recast.py
    https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/blob/master/cfn/encoding/stringify.go
    and more examples.
  2. Certain properties can have multiple types defined with the new resource type schemas

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PatMyron
Copy link
Contributor

linking #547

@kddejong kddejong merged commit 56e8440 into aws-cloudformation:main Sep 2, 2021
@kddejong kddejong deleted the rules/E3012/changedefault branch September 2, 2021 15:17
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants