Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor dashboard #411

Merged
merged 25 commits into from
Apr 3, 2023
Merged

refactor dashboard #411

merged 25 commits into from
Apr 3, 2023

Conversation

josefaidt
Copy link
Contributor

@josefaidt josefaidt commented Mar 24, 2023 •
edited
Loading

Issue #, if available:

closes #370
closes #377
closes #364

Description of changes:

  • adds group-by helpers
  • adds filter-by helpers
  • adds Tag filtering
  • adds two pie charts for Tags
  • adds Tag health table
  • adds constants to ensure filtering, grouping, and inputs use the same conventions
  • adds ValueOf TypeScript helper
  • refactors filtering, grouping
  • refactors server load
  • refactors helper directory, organization
  • refactors out GitHub helpers
  • refactors component directory
  • modifies CSV download to include filtered dataset

localhost_3000_dashboard (2)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@josefaidt josefaidt changed the title refactor dashboard helpers refactor dashboard Mar 29, 2023
@josefaidt josefaidt marked this pull request as ready for review April 2, 2023 20:58
@josefaidt josefaidt requested a review from a team April 2, 2023 20:58
@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Apr 2, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Apr 2, 2023
@josefaidt josefaidt temporarily deployed to ci April 2, 2023 21:38 — with GitHub Actions Inactive
cwomack
cwomack previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@cwomack cwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Apr 3, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Apr 3, 2023
@josefaidt josefaidt temporarily deployed to ci April 3, 2023 19:03 — with GitHub Actions Inactive
@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Apr 3, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Apr 3, 2023
@josefaidt josefaidt temporarily deployed to ci April 3, 2023 21:30 — with GitHub Actions Inactive
cwomack
cwomack approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@cwomack cwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Apr 3, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Apr 3, 2023
@josefaidt josefaidt temporarily deployed to ci April 3, 2023 23:39 — with GitHub Actions Inactive
@josefaidt josefaidt merged commit f3773a3 into aws-amplify:main Apr 3, 2023
@josefaidt josefaidt deleted the refactor-dashboard-helpers branch April 3, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwomack cwomack cwomack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@josefaidt @cwomack