Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Events deleted from local DB on failures when device is offline #3038

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: Events deleted from local DB on failures when device is offline #3038

merged 2 commits into from
Oct 17, 2022

Conversation

sdhuka
Copy link
Contributor

@sdhuka sdhuka commented Oct 17, 2022

Issue #3033, if #available:#

Description of changes:

  • Add check to prevent syncing events when the device is offline.
  • Add additional check when an exception is nested.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdhuka sdhuka requested a review from a team as a code owner October 17, 2022 15:15
@sdhuka sdhuka merged commit c6bec63 into main Oct 17, 2022
@sdhuka sdhuka deleted the sdhuka/fix-pinpoint-sync branch October 17, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjleing tjleing tjleing approved these changes

@tylerjroach tylerjroach tylerjroach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdhuka @tylerjroach @tjleing