Fix: API 30+ fix for opening Pinpoint push notification links #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhuka
previously approved these changes
Jun 8, 2022
sktimalsina
reviewed
Jun 8, 2022
| pinpointContext.getApplicationContext().startActivity(intent); | ||
| } catch (ActivityNotFoundException e) { | ||
| log.error("Couldn't find an app to open ACTION_VIEW Intent."); |
There was a problem hiding this comment.
Can we include e or e.getMessage for additional context on error?
There was a problem hiding this comment.
We can, but it won't really provide any additional context. In this instance the only scenario here is that the user does not have a browser app installed.
sktimalsina
reviewed
Jun 8, 2022
sktimalsina
previously approved these changes
Jun 8, 2022
tylerjroach
changed the title
tjleing
approved these changes
Jun 8, 2022
sktimalsina
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Android 30+ no longer allows you to query packages without adding a query tag in the manifest. Rather than add that tag, a more simple approach is to go ahead and try to start an activity and catch the exception.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.