Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ai): adding UA string for AIConversation #5917

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

dbanksdesign
Copy link
Contributor

Description of changes

Adds custom UA string for AIConversation component. Bumps the minimum aws-amplify version to 6.6.5 for all packages.

Issue #, if available

Description of how you validated changes

CleanShot 2024-10-16 at 20 47 37@2x

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbanksdesign dbanksdesign requested a review from a team as a code owner October 17, 2024 03:55
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 4e98505

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jordanvn
jordanvn previously approved these changes Oct 17, 2024
Copy link
Member

@jordanvn jordanvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, once test failures are resolved

dbanksdesign and others added 2 commits October 17, 2024 10:36
Co-authored-by: Jordan Van Ness <jordvn@amazon.com>
Copy link
Member

@ashika112 ashika112 Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something new for UI repo? And needed to maintained manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anything new, a pattern we have for all UI packages where we use the UA string. We have a script to update the version number on build. This is so we don't have to import package.json

@dbanksdesign dbanksdesign merged commit 3655af2 into main Oct 17, 2024
36 checks passed
@dbanksdesign dbanksdesign deleted the ai-ua-string branch October 17, 2024 21:45
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants