Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: major version bump to v6 #4724

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Conversation

reesscot
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: ed390da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@reesscot reesscot changed the title Major version bump feat: major version bump Nov 14, 2023
@reesscot reesscot marked this pull request as ready for review November 14, 2023 21:20
@reesscot reesscot requested a review from a team as a code owner November 14, 2023 21:20
@reesscot reesscot force-pushed the reesscot/major-version-bump branch from babf603 to 44d2d68 Compare November 14, 2023 21:46
@reesscot reesscot force-pushed the reesscot/major-version-bump branch from 064a239 to c5f8f30 Compare November 14, 2023 21:55
calebpollman
calebpollman previously approved these changes Nov 14, 2023
thaddmt
thaddmt previously approved these changes Nov 14, 2023
@reesscot reesscot dismissed stale reviews from thaddmt and calebpollman via d485148 November 14, 2023 21:57
"@aws-amplify/ui-react": "^5.3.2",
"@aws-amplify/ui-react-geo": "^1.0.2",
"@aws-amplify/ui-react": "^6.0.0",
"@aws-amplify/ui-react-geo": "^2.0.0",
"@aws-amplify/ui-react-liveness": "^2.0.11",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left this since we didn't bump liveness

esauerbo
esauerbo previously approved these changes Nov 14, 2023
packages/vue/CHANGELOG.md Outdated Show resolved Hide resolved
reesscot and others added 2 commits November 14, 2023 15:00
@reesscot reesscot changed the title feat: major version bump BREAKING CHANGE: major version bump to v6 Nov 14, 2023
esauerbo
esauerbo previously approved these changes Nov 14, 2023
calebpollman
calebpollman previously approved these changes Nov 14, 2023
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

dbanksdesign
dbanksdesign previously approved these changes Nov 14, 2023
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

package.json Outdated
@@ -122,5 +122,6 @@
"turbo": "^1.2.8",
"typescript": "^5.2.2",
"wait-on": "^6.0.0"
}
},
"version": "0.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,11 @@
# @aws-amplify/ui-react-auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @aws-amplify/ui-react-auth

@reesscot reesscot merged commit c9a969d into main Nov 14, 2023
10 of 11 checks passed
@reesscot reesscot deleted the reesscot/major-version-bump branch November 14, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants