-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add missing form fields to RNA example app #4583
chore: Add missing form fields to RNA example app #4583
Conversation
|
updated_at: { | ||
label: 'Updated at', | ||
isRequired: false, | ||
type: 'text', | ||
}, | ||
address: { | ||
label: 'Address', | ||
isRequired: false, | ||
type: 'text', | ||
}, | ||
gender: { | ||
label: 'Gender', | ||
isRequired: false, | ||
type: 'text', | ||
}, | ||
locale: { | ||
label: 'Locale', | ||
isRequired: false, | ||
type: 'text', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how much value including these in the example code provides, imo kind of bloats the example code. Are the keys not documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cognito is configured with these attributes as required, and once created we can't modify the user pool attributes. The value is that we can perform manual tests with this app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this example used in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, docs use this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
The base branch was changed.
bb65e5b
into
next-release/merge-main-to-migration
Description of changes
Add missing fields from signup with attributes RNA example app.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.