Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing form fields to RNA example app #4583

Merged

Conversation

ioanabrooks
Copy link
Contributor

Description of changes

Add missing fields from signup with attributes RNA example app.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ioanabrooks ioanabrooks requested a review from a team as a code owner October 25, 2023 17:31
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: 447a036

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2023 17:49 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2023 17:49 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2023 17:49 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2023 17:49 — with GitHub Actions Inactive
dbanksdesign
dbanksdesign previously approved these changes Oct 25, 2023
Comment on lines +29 to +48
updated_at: {
label: 'Updated at',
isRequired: false,
type: 'text',
},
address: {
label: 'Address',
isRequired: false,
type: 'text',
},
gender: {
label: 'Gender',
isRequired: false,
type: 'text',
},
locale: {
label: 'Locale',
isRequired: false,
type: 'text',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much value including these in the example code provides, imo kind of bloats the example code. Are the keys not documented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cognito is configured with these attributes as required, and once created we can't modify the user pool attributes. The value is that we can perform manual tests with this app.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this example used in the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, docs use this example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@ioanabrooks ioanabrooks changed the base branch from next-release/migration to next-release/main October 28, 2023 15:49
@ioanabrooks ioanabrooks dismissed dbanksdesign’s stale review October 28, 2023 15:49

The base branch was changed.

@ioanabrooks ioanabrooks changed the base branch from next-release/main to next-release/merge-main-to-migration October 28, 2023 15:49
@reesscot reesscot merged commit bb65e5b into next-release/merge-main-to-migration Oct 31, 2023
21 checks passed
@reesscot reesscot deleted the next-release/migration-rna-app branch October 31, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants