Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix unused var #4491

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore: Fix unused var #4491

merged 2 commits into from
Sep 28, 2023

Conversation

ioanabrooks
Copy link
Contributor

Description of changes

Fix unused var issue in https://github.com/aws-amplify/amplify-ui/security/code-scanning/159

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ioanabrooks ioanabrooks requested a review from a team as a code owner September 28, 2023 01:29
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

⚠️ No Changeset found

Latest commit: e1c000f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

log('info', `Checking log file ${logFileName} for errors...`);
log(
'info',
`Checking log file ${logFileName} on ${platform} platform for errors...`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous commit I removed the usage of the platform var (it was used to have a slower timeout on ios than android, but ios tests were flaky so using same timeout now). Didn't want to entirely remove the platform var since it may come in handy in the future. Using it in log for now.

.vscode/settings.json Outdated Show resolved Hide resolved
reesscot
reesscot previously approved these changes Sep 28, 2023
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 01:45 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 01:45 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 01:45 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 01:45 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 18:19 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 18:19 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 18:19 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci September 28, 2023 18:19 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks enabled auto-merge (squash) September 28, 2023 19:51
@ioanabrooks ioanabrooks merged commit 1b2f290 into main Sep 28, 2023
@ioanabrooks ioanabrooks deleted the unused-vars branch September 28, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants