feat(@aws-amplify/analytics): Analytics Typescript updates #9272
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9272 +/- ##
=======================================
Coverage 78.29% 78.29%
=======================================
Files 250 250
Lines 18258 18258
Branches 3927 3927
=======================================
Hits 14296 14296
Misses 3832 3832
Partials 130 130
Continue to review full report at Codecov.
|
| public async record( | ||
| event: string | object, | ||
| provider?, | ||
| eventName: string, | ||
| attributes?: EventAttributes, | ||
| metrics?: EventMetrics | ||
| ); |
There was a problem hiding this comment.
is this something we allow too?
There was a problem hiding this comment.
I believe this is the old way of using Analytics.record (at least from the implementation, this is supported)
There was a problem hiding this comment.
Gotcha. I dont see documentation on it. Do u think we can add this usage in docs with a deprecation notice?
…ws-amplify#9272)" This reverts commit 9a52c2b.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
Analytics.recordfunctionanywherever possibleAnalytics.record@deprecatedIssue #, if available
related #9162
Description of how you validated changes
yarn clean && yarn setup-dev
yarn test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.