Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade crypto-js to 4.1.1 #8626

Merged
merged 2 commits into from
Jul 22, 2021
Merged

upgrade crypto-js to 4.1.1 #8626

merged 2 commits into from
Jul 22, 2021

Conversation

hkjpotato
Copy link
Contributor

@hkjpotato hkjpotato commented Jul 22, 2021

Description of changes

upgrade crypto-js to include the bundle size fix brix/crypto-js#364

This fixes #7570

Comparison of bundle sizes
webpack umd nextjs (first load js) auth/dist/aws-amplify-auth-js
before 17.1 MB 281 kB 1.5 MB
after 15.7 MB ~147 kB 454K

Because crypto-js has upgraded, I will close the previous PR on deprecating crypto-js. Also create an internal TT for further investigation.

Issue #, if available

#7570

Description of how you validated changes

  • yarn test
  • I made and verified the origin fix in the crypto-js upgrade.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hkjpotato hkjpotato requested a review from elorzafe as a code owner July 22, 2021 12:41
@hkjpotato hkjpotato requested a review from aws-eddy July 22, 2021 12:42
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hkjpotato !! 🌮 🎉 🎖️

@hkjpotato hkjpotato removed the request for review from aws-eddy July 22, 2021 16:32
@codecov-commenter
Copy link

Codecov Report

Merging #8626 (1c61bf3) into main (569214c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8626      +/-   ##
==========================================
+ Coverage   77.79%   77.80%   +0.01%     
==========================================
  Files         240      240              
  Lines       17121    17121              
  Branches     3650     3650              
==========================================
+ Hits        13319    13321       +2     
+ Misses       3677     3675       -2     
  Partials      125      125              
Impacted Files Coverage Δ
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.71% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569214c...1c61bf3. Read the comment docs.

@hkjpotato hkjpotato mentioned this pull request Jul 22, 2021
4 tasks
@hkjpotato hkjpotato merged commit b16f8e7 into main Jul 22, 2021
@hkjpotato hkjpotato deleted the kj/upgrade-crypto-js branch July 27, 2021 19:36
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Amplify Auth to a Next.js project has a huge impact of the chunk size
4 participants