chore: bump bundle limits for crypto-js@4 bump #8321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8321 +/- ##
==========================================
+ Coverage 77.91% 77.95% +0.03%
==========================================
Files 236 236
Lines 16548 16555 +7
Branches 3559 3560 +1
==========================================
+ Hits 12894 12905 +11
+ Misses 3543 3539 -4
Partials 111 111
Continue to review full report at Codecov.
|
reesscot
approved these changes
May 20, 2021
2 tasks
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some bundle size checks are failing after upgrading to
crypto-js@4. This PR bumps those limits to prevent us from becoming blind to other bundle size spikes. A GH issues will be created for us to re-examine our usage ofcrypto-js@4and try to tamp bundle size back down.Issue #, if available
Description of how you validated changes
No changes to library codebase. Tested new bundle limits with
rm -rf node_modules && yarn && yarn calculatefor eachbundle-size-action.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.