Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Upgrade to @react-native-async-storage/async-storage #8250

Merged
merged 9 commits into from
May 10, 2021
Merged

Conversation

amhinson
Copy link
Contributor

@amhinson amhinson commented May 10, 2021

Description of changes

  • Upgrade from React Native's AsyncStorage to @react-native-async-storage/async-storage
    This will be a major version bump due to React Native customers needing to also install @react-native-async-storage/async-storage as a dependency in their app.

Issue #, if available

#6031

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amhinson amhinson requested a review from manueliglesias as a code owner May 10, 2021 18:20
@amhinson amhinson changed the title BREAKING CHANGE: Upgrade to @react-native-async-storage/async-storage refactor!: Upgrade to @react-native-async-storage/async-storage May 10, 2021
@amhinson amhinson changed the title refactor!: Upgrade to @react-native-async-storage/async-storage chore!: Upgrade to @react-native-async-storage/async-storage May 10, 2021
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻
Tested this change against a DataStore RN sample with iOS and Android

@amhinson amhinson requested a review from sammartinez May 10, 2021 19:32
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT and I'm good

README.md Show resolved Hide resolved
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀
Left some suggestions.

@@ -90,8 +91,11 @@
"eslint-plugin-standard": "^3.0.1",
"jsdoc": "^3.4.0",
"react": "^16.0.0",
"react-native": "^0.44.0",
"react-native": "^0.59.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move to version 0.60.0 and above now that we are releasing a new major version?

README.md Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
@jimblanc jimblanc deleted the native branch November 23, 2022 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants