-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Upgrade to @react-native-async-storage/async-storage #8250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
Tested this change against a DataStore RN sample with iOS and Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One NIT and I'm good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Left some suggestions.
@@ -90,8 +91,11 @@ | |||
"eslint-plugin-standard": "^3.0.1", | |||
"jsdoc": "^3.4.0", | |||
"react": "^16.0.0", | |||
"react-native": "^0.44.0", | |||
"react-native": "^0.59.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to move to version 0.60.0
and above now that we are releasing a new major version?
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
AsyncStorage
to@react-native-async-storage/async-storage
This will be a major version bump due to React Native customers needing to also install
@react-native-async-storage/async-storage
as a dependency in their app.Issue #, if available
#6031
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.