deps: pin amplify versions #7040
Conversation
wlee221
requested review from
Ashish-Nanda,
elorzafe,
iartemiev and
manueliglesias
as code owners
|
Not familiar with how lerna handles version bumps, will lerna no longer add 🥕 based on this commit? |
@iartemiev would know more so on this. |
We can force the version using
|
Codecov Report
@@ Coverage Diff @@
## main #7040 +/- ##
=======================================
Coverage 72.99% 72.99%
=======================================
Files 213 213
Lines 13321 13321
Branches 2610 2514 -96
=======================================
Hits 9724 9724
- Misses 3401 3432 +31
+ Partials 196 165 -31
Continue to review full report at Codecov.
|
|
Running integration on https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/6509/workflows/781214eb-0d4a-4781-857b-3a1151ec661d. I will have to test for duplicate packages in modular import scenarios. eta. this Fri. |
|
To do based on today's discussion: we should test that there are no duplicated packages when customers install divergent |
| "npmClient": "yarn", | ||
| "useWorkspaces": true, | ||
| "packages": ["packages/*"], | ||
| "exact": true, |
There was a problem hiding this comment.
This is equivalent to --exact tag.
|
Based on our offline discussion today, this is ready to be reviewed. |
There was a problem hiding this comment.
LGTM 🌮 Thanks for getting this change in @wlee221. Lets get @iartemiev and @ericclemmons to approve and we will be good to merge
There was a problem hiding this comment.
Great work @wlee221!
This will allow customers to "roll back" to a previous version if they have any issues. Plus, it'll allow us to reproduce issues more easily using their exact version!
I added a few notes regarding peerDependencies for legacy packages (e.g. aws-amplify-react) to avoid warnings since they're unpinned.
IIRC, lerna doesn't manage peerDependencies, so those can remain as ^3.0.0? Otherwise can they be 3.x.x?
I don't consider this a blocker, but possible noise when customers install...
| "rxjs-compat": "^6.2.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "aws-amplify": "^3.0.0" | ||
| "aws-amplify": "3.0.0" |
There was a problem hiding this comment.
This can be 3.x.x, right? Otherwise every non 3.0.0 version will have a warning?
(I understand it's been this way since 3.0.0)
There was a problem hiding this comment.
Thanks for the catch! You're right, I'll change them to range again.
|
Thanks everyone for the help! Merging it in now. |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes: This pins amplify versions across our monorepo. See #6972 for discussions. 🥕
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.