Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async storage -> community #4027

Closed
wants to merge 1 commit into from
Closed

async storage -> community #4027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/amazon-cognito-identity-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
"js-cookie": "^2.1.4"
},
"devDependencies": {
"@react-native-community/async-storage": "^1.6.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can update to latest version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpaas can you resolve this?

"babel-cli": "^6.23.0",
"babel-core": "^6.13.2",
"babel-loader": "^6.2.4",
Expand All @@ -84,7 +85,7 @@
"eslint-plugin-standard": "^3.0.1",
"jsdoc": "^3.4.0",
"react": "^16.0.0",
"react-native": "^0.44.0",
"react-native": "^0.60.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update RN version here too

"rimraf": "^2.5.4",
"webpack": "^3.5.5"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/amazon-cognito-identity-js/src/StorageHelper-rn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

import { AsyncStorage } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';

const MEMORY_KEY_PREFIX = '@MemoryStorage:';
let dataMemory = {};
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-amplify-react-native/docs/Cache_AsyncStorageCache.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h1 class="page-title">Source: Cache/AsyncStorageCache.js</h1>

import StorageCache from './StorageCache';
import {defaultConfig, getCurrTime} from './Utils/CacheUtils'
import { AsyncStorage } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';

import { ConsoleLogger as Logger } from '../Common';

Expand Down
2 changes: 1 addition & 1 deletion packages/cache/src/AsyncStorageCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import StorageCache from './StorageCache';
import {defaultConfig, getCurrTime} from './Utils/CacheUtils';
import { AsyncStorage } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';
import { ICache, CacheConfig, CacheItem, CacheItemOptions } from './types';
import { ConsoleLogger as Logger } from '@aws-amplify/core';

Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/RNComponents/reactnative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* and limitations under the License.
*/

import { Linking, AppState, AsyncStorage } from 'react-native';
import { Linking, AppState } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';

export { Linking, AppState, AsyncStorage };
2 changes: 1 addition & 1 deletion packages/core/src/StorageHelper/reactnative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions
* and limitations under the License.
*/
import { AsyncStorage } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';

const MEMORY_KEY_PREFIX = '@MemoryStorage:';
let dataMemory = {};
Expand Down
3 changes: 2 additions & 1 deletion packages/pushnotification/src/PushNotification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
* and limitations under the License.
*/

import { NativeModules, DeviceEventEmitter, AsyncStorage, PushNotificationIOS, Platform, AppState } from 'react-native';
import { NativeModules, DeviceEventEmitter, PushNotificationIOS, Platform, AppState } from 'react-native';
import AsyncStorage from '@react-native-community/async-storage';
import Amplify, { ConsoleLogger as Logger } from '@aws-amplify/core';

const logger = new Logger('Notification');
Expand Down