Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui components/form #3790

Merged
merged 31 commits into from
Aug 6, 2019
Merged

Ui components/form #3790

merged 31 commits into from
Aug 6, 2019

Conversation

sammartinez
Copy link
Contributor

Description of changes:

  • Setup base form feature branch, fixed merge conflicts from amplify-ui-components to ui-components/form

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tjleing and others added 30 commits July 3, 2019 11:38
* Amplify stencil components

* New components

* Generate component docs

* Update es module to match script

* Trying amplify-scene with Amplify imported

* Update stencil to 1.0

* feat: amplify-scene and readme build

* feat: add storybook and button story

* feat: storybook integration and button component changes

* Fix Vue build error and update yarn lock

* Remove exports

* Remove package lock from core
* Remove husky pre-hooks until linting is functioning

* Clean up linter

* Revert quotation change
* Move amplify-ui-components package from npm to yarn

* Add visual screenshot testing to amplify-text-field, and fix jest-config problem manually

* Bump stencil version + husky pre-push testing
@sammartinez sammartinez self-assigned this Aug 1, 2019
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to work on this!

packages/amplify-ui-components/Readme.md Show resolved Hide resolved
packages/amplify-ui-components/package.json Show resolved Hide resolved
};

render() {
const tunnerState = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's a new one

Copy link
Contributor

@jordanranz jordanranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sammartinez sammartinez merged commit 089891e into aws-amplify:ui-components/form Aug 6, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants