Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): avoid using implicit dependencies for auth #14122

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

pranavosu
Copy link
Member

@pranavosu pranavosu commented Jan 8, 2025

Description of changes

Added missing dependencies

Issue #, if available

#13024

Description of how you validated changes

  • replicated issue using npm@8 & vite starter template
  • npm install aws-amplify preid version 6.12.1-crypto-dep-fix.c868501.0
  • install works
  • app runs

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pranavosu pranavosu requested a review from a team as a code owner January 9, 2025 19:57
@pranavosu pranavosu merged commit f2a0b74 into main Jan 10, 2025
30 checks passed
@pranavosu pranavosu deleted the fix/crypto-dep branch January 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants