Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtn-push-notification): wrong namespace is being used #14060

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Dec 9, 2024

Description of changes

Fix wrong namespace.

Issue #, if available

#14059

Description of how you validated changes

Manually build android app with installing the locally modified @aws-amplify/rtn-push-notification package and verify that npm run android can build the native Android host app with react-native versions:

  1. 0.73.6
  2. 0.70.0

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner December 9, 2024 17:41
@HuiSF HuiSF merged commit bc37719 into v5-stable Dec 9, 2024
28 checks passed
@HuiSF HuiSF deleted the hui/fix/android-pn-build branch December 9, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants