release(required): network error has not been properly detected #13935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
isConnectionError
of thedefaultRetryDecider
now detects network errors by looking up thename
property to match either one of the[NetworkError, ERR_NETWORK]
NetworkError
is thrown from the fetch transfer handler CoreERR_NETWORK
is thrown from the XHR transfer handler resides in StoragetokenOrchestrator.handleErrors
method now detects network errors by looking up thename
property to matchNetworkError
,clearTokens()
shall not be called when the error is a network errorIssue #, if available
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.