feat(auth): [EMAIL MFA] Sign In / Confirm Sign In With MFA_SETUP #13760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjarvisp
changed the title
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
a852083 to
eeb8249
Compare
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
fff1814 to
9d0989d
Compare
israx
suggested changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for putting this together.
Keeping track of state at 2 different places can be problematic. It introduces complexity when debugging, refactoring, and scaling. It can also lead to bugs. My concern is that when adding resumable-sign-in, the new store would also need to store state in sessionStorage.
To avoid all of that, we can keep handling the same state that is managed by the signInStore and keep the sign-in flow between the getSignInResult and handleChallengeName helpers. If we want to add some extra state, we can add some metadata in the signInStore — I don't see the need but I'll leave it up to you.
Bellow I added a flow diagram that shows the sign-in flow between the handleChangeName and getSignInResult helpers when challengeName is MFA_SETUP
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
7b30970 to
eee2523
Compare
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
eee2523 to
33a98c8
Compare
israx
reviewed
Aug 28, 2024
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
16b351a to
69fdb0a
Compare
jjarvisp
force-pushed
the
feat/email-mfa-setup
branch
from
69fdb0a to
b5e8fed
Compare
israx
approved these changes
Aug 28, 2024
jjarvisp
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
HuiSF
as code owners
HuiSF
changed the title
jjarvisp
added a commit
that referenced
this pull request
Oct 31, 2024
* [Email MFA] Updating fetchMFAPreference and updateMFAPreference (#13720) * add EMAIL MFA option in fetchMFAPreference * add EMAIL MFA option in updateMFAPreference * update fetchMFAPreference tests * update updateMFAPreference tests * update bundle size * remove redundant assertions * [Email MFA] Add support for EMAIL_OTP during sign in flows (#13745) * Confirm Sign In With Email OTP * Confirm Sign In Tests With Email OTP * Update packages/auth/src/types/models.ts Co-authored-by: israx <70438514+israx@users.noreply.github.com> * Fix Errant Pascal Casing --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com> * feat(auth): [EMAIL MFA] Sign In / Confirm Sign In With MFA_SETUP (#13760) * Sign In / Confirm Sign In With MFA_SETUP * Sign In State Management Tests * Confirm Sign In Happy Path Tests * Fix State Management Tests * Apply Feedback * loose email matching * Remove Unnecessary Export * Update SignInHelpers For Getting Allowed MFA Setup Types * Add Error Case Unit Tests * feat(auth): [EMAIL MFA] enable integ tests with backend configuration swapping (#13794) * chore: enable mfa integ tests * chore: add mfa-setup test def * chore: temporarily enable push integ tests * chore: disable push integ tests * chore: address test strategy feedback * chore: use trimmed challenge response * chore: improved naming * chore: update bundle size tests * chore: remove trimmed challenge response --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The purpose of this pull request is to expand the MFA_SETUP challenge to support setting up and signing in with multiple MFA setup options - EMAIL and TOTP.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.