Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): decouple utils from Amplify singleton #13562

Merged
merged 12 commits into from
Jul 10, 2024
Merged

refactor(storage): decouple utils from Amplify singleton #13562

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cf1a356
feat: add config constructor
israx Jul 3, 2024
a2f38fb
refactor: remove singleton reference from storage utils
israx Jul 3, 2024
f7a35ec
refactor: update storage utils
israx Jul 3, 2024
257ac11
chore: update upload api
israx Jul 3, 2024
e53750d
chore: address feedback
israx Jul 9, 2024
a1740b7
chore: fix unit tests
israx Jul 9, 2024
3763f49
chore: remove singleton reference
israx Jul 9, 2024
96a2fb4
chore: add license headers
israx Jul 9, 2024
345252a
chore: address feedback
israx Jul 10, 2024
8e9ef6b
chore: update bundle size
israx Jul 10, 2024
9633d19
chore: address feedback
israx Jul 10, 2024
834c54c
chore: update bundle size
israx Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/storage/__tests__/providers/s3/apis/uploadData/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,12 @@ describe('uploadData with path', () => {
uploadData(testInput);

expect(mockPutObjectJob).toHaveBeenCalledWith(
testInput,
expect.any(AbortSignal),
expect.any(Number),
expect.objectContaining({
input: testInput,
totalLength: expect.any(Number),
abortSignal: expect.any(AbortSignal),
config: expect.any(Object),
}),
);
expect(mockGetMultipartUploadHandlers).not.toHaveBeenCalled();
},
Expand Down Expand Up @@ -212,8 +215,11 @@ describe('uploadData with path', () => {

expect(mockPutObjectJob).not.toHaveBeenCalled();
expect(mockGetMultipartUploadHandlers).toHaveBeenCalledWith(
testInput,
expect.any(Number),
expect.objectContaining({
config: expect.any(Object),
input: testInput,
size: expect.any(Number),
}),
);
});

Expand Down
Loading
Loading