Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds InternalAuth to requiredModules for SSR #11837

Merged

Conversation

erinleigh90
Copy link
Contributor

Description of changes

Fixes issue where InternalAuth missing from withSSRContext when only the API module is included.

  • Adds InternalAuth as a requiredModule - it will be used for DataStore, API, and eventually Credentials.

Issue #, if available

Description of how you validated changes

Tested in a sample app where I was able to verify there was an issue and fix with the included code.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@erinleigh90 erinleigh90 requested a review from a team as a code owner August 18, 2023 22:14
@codecov-commenter
Copy link

Codecov Report

Merging #11837 (2dcd389) into main (b6987fc) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11837      +/-   ##
==========================================
- Coverage   84.07%   84.07%   -0.01%     
==========================================
  Files         350      350              
  Lines       21173    21172       -1     
  Branches     4452     4452              
==========================================
- Hits        17802    17801       -1     
  Misses       3110     3110              
  Partials      261      261              
Files Changed Coverage Δ
packages/aws-amplify/src/withSSRContext.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erinleigh90 erinleigh90 merged commit 471cf2a into aws-amplify:main Aug 21, 2023
@erinleigh90 erinleigh90 deleted the fix/ssr-context-api-internal-auth branch August 21, 2023 18:36
stocaaro added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants