-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom user agent InternalCognitoUserPool #11716
Merged
erinleigh90
merged 18 commits into
aws-amplify:main
from
erinleigh90:feat/internal-cognito-user-pool
Aug 8, 2023
Merged
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5fa456c
chore: port CognitoUserPool over to InternalCognitoUserPool
erinleigh90 8f74304
chore: restore CognitoUserPool
erinleigh90 1b8553a
feat: add userAgentValue parameter to signUp
erinleigh90 2c0d9c6
feat: update class name and imports
erinleigh90 7995aa6
feat: make CognitoUserPool extend internal and override signUp
erinleigh90 5b216a6
feat: export InternalCognitoUserPool from internals index
erinleigh90 e45491d
feat: send userAgentValue to client service call
erinleigh90 622bb40
test: fix internalsIndex test
erinleigh90 bcf5946
build: export InternalCognitoUserPool from internals scope
erinleigh90 11e22ad
chore: update CognitoUserPool type to extend internal
erinleigh90 47bdc82
Apply suggestions from code review
erinleigh90 da598e5
Merge branch 'main' into feat/internal-cognito-user-pool
jimblanc fa119f3
Merge branch 'main' into feat/internal-cognito-user-pool
israx 6484b45
chore: remove unnecessary test on internals index
erinleigh90 c80f836
Merge branch 'main' into feat/internal-cognito-user-pool
erinleigh90 7b45e4a
Merge branch 'main' into feat/internal-cognito-user-pool
erinleigh90 6aaea85
chore: increase bundle size limit
erinleigh90 59be057
Merge branch 'main' into feat/internal-cognito-user-pool
erinleigh90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I know the only diff here is arity and exposing the extended interface for internals. Is it worth adding test coverage for the internals surface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I originally added this test as a part of the cognitoUserAgent changes, I was attempting to reflect the other test class on main auth exports. However, it does seem rather redundant and we probably don't need it. I will remove the test.