-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/custom user agent UI/storage #11685
Merged
erinleigh90
merged 33 commits into
aws-amplify:feat/custom-user-agent-ui/main
from
erinleigh90:feat/custom-user-agent-ui/storage
Jul 26, 2023
Merged
Feat/custom user agent UI/storage #11685
erinleigh90
merged 33 commits into
aws-amplify:feat/custom-user-agent-ui/main
from
erinleigh90:feat/custom-user-agent-ui/storage
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4bc7c48.
* chore: copy InAppMessaging to InternalInAppMessaging * feat: add customUserAgentDetails param to InternalInAppMessaging * feat: make InAppMessaging extend InternalInAppMessaging * feat: send sync userAgentDetails through to service call * fix: add SyncMessages value to InAppMessagingAction * chore: remove extra parameter from non-service-call functions * fix: fix typo in InAppMessagingAction * feat: send user agent details through identify user to service call * chore: remove unused import * feat: allow InAppMessaging to be configured independently of Notifications * test: update tests for internal changes * build: export InternalInAppMessaging from scoped path * fix: resolve bundle size * chore: bundle size settings * chore: increase bundle size limits * chore: fix typo * fix: update references to type with typo
* chore: copy Geo code into InternalGeo * feat: add geo actions * feat: add customUserAgentDetails to geo provider * feat: add customUserAgentDetails to public api's and send to service calls * feat: make Geo extend InternalGeo and override public API's * build: export InternalGeo from scoped geo/internals path * chore: increase bundle size limits * chore: increase bundle size limits * feat: add user agent param to action that was missed * chore: update doc-strings with new param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.