Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): missing Size in listParts output #11559

Merged

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Jun 29, 2023

Description of changes

  • Fix multipart upload doesn't complete on resume when all parts have been uploaded previously
  • Fix custom S3 client listParts output doesn't include the Size property

Issue #, if available

Description of how you validated changes

  • Local testing
  • Unit testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner June 29, 2023 19:38
Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@codecov-commenter
Copy link

Codecov Report

Merging #11559 (679d78a) into v5/custom-clients (3e2c1a9) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                  @@
##           v5/custom-clients   #11559      +/-   ##
=====================================================
+ Coverage              83.61%   83.65%   +0.03%     
=====================================================
  Files                    317      336      +19     
  Lines                  21281    21491     +210     
  Branches                4552     4586      +34     
=====================================================
+ Hits                   17795    17978     +183     
- Misses                  3198     3226      +28     
+ Partials                 288      287       -1     

see 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HuiSF HuiSF changed the title fix(storage): missing Size in listParts output @HuiSF fix(storage): missing Size in listParts output Jun 29, 2023
Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@HuiSF HuiSF merged commit 4085319 into aws-amplify:v5/custom-clients Jun 29, 2023
@HuiSF HuiSF deleted the hui/fix/storage-multipart-upload branch June 29, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants