Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): support copy/delete/get/head object APIs #11515

Conversation

AllanZhengYP
Copy link
Member

Description of changes

Support S3 client APIs:

  • CopyObject
  • DeleteObject
  • GetObject
  • HeadObject

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner June 18, 2023 21:02
@codecov-commenter
Copy link

Codecov Report

Merging #11515 (e287dfa) into v5/custom-clients (9efe09a) will increase coverage by 0.05%.
The diff coverage is 93.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                  @@
##           v5/custom-clients   #11515      +/-   ##
=====================================================
+ Coverage              83.49%   83.54%   +0.05%     
=====================================================
  Files                    299      307       +8     
  Lines                  20997    21109     +112     
  Branches                4526     4534       +8     
=====================================================
+ Hits                   17531    17636     +105     
- Misses                  3178     3185       +7     
  Partials                 288      288              
Impacted Files Coverage Δ
packages/storage/src/AwsClients/S3/deleteObject.ts 88.23% <88.23%> (ø)
packages/storage/src/AwsClients/S3/copyObject.ts 89.47% <89.47%> (ø)
packages/storage/src/AwsClients/S3/headObject.ts 89.47% <89.47%> (ø)
packages/storage/src/AwsClients/S3/getObject.ts 90.00% <90.00%> (ø)
...torage/__tests__/AwsClients/S3/cases/copyObject.ts 100.00% <100.00%> (ø)
...rage/__tests__/AwsClients/S3/cases/deleteObject.ts 100.00% <100.00%> (ø)
...storage/__tests__/AwsClients/S3/cases/getObject.ts 100.00% <100.00%> (ø)
...torage/__tests__/AwsClients/S3/cases/headObject.ts 100.00% <100.00%> (ø)
...ges/storage/__tests__/AwsClients/S3/cases/index.ts 100.00% <100.00%> (ø)
packages/storage/src/AwsClients/S3/index.ts 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AllanZhengYP AllanZhengYP requested a review from HuiSF June 19, 2023 19:41
@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-object-apis branch from 202b62a to bfc4bee Compare June 19, 2023 21:23
@AllanZhengYP AllanZhengYP merged commit 3e2c1a9 into aws-amplify:v5/custom-clients Jun 19, 2023
kvramyasri7 pushed a commit to kvramyasri7/amplify-js that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants