Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): implement multiparts upload APIs #11514

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Jun 17, 2023

Description of changes

Support the multipart upload APIs on the S3 client:

  • CreateMultipartUpload
  • AbortMultipartUpload
  • UploadPart
  • CompleteMultipartUpload
  • ListParts

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review June 18, 2023 19:23
@AllanZhengYP AllanZhengYP requested review from a team as code owners June 18, 2023 19:23
@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-multiparts branch from eb7b076 to ab35838 Compare June 18, 2023 21:04
@codecov-commenter
Copy link

Codecov Report

Merging #11514 (ab35838) into v5/custom-clients (9efe09a) will increase coverage by 0.07%.
The diff coverage is 93.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                  @@
##           v5/custom-clients   #11514      +/-   ##
=====================================================
+ Coverage              83.49%   83.57%   +0.07%     
=====================================================
  Files                    299      309      +10     
  Lines                  20997    21166     +169     
  Branches                4526     4545      +19     
=====================================================
+ Hits                   17531    17689     +158     
- Misses                  3178     3189      +11     
  Partials                 288      288              
Impacted Files Coverage Δ
.../storage/src/AwsClients/S3/abortMultipartUpload.ts 88.88% <88.88%> (ø)
packages/storage/src/AwsClients/S3/uploadPart.ts 89.47% <89.47%> (ø)
...storage/src/AwsClients/S3/createMultipartUpload.ts 90.47% <90.47%> (ø)
packages/storage/src/AwsClients/S3/listParts.ts 92.00% <92.00%> (ø)
...orage/src/AwsClients/S3/completeMultipartUpload.ts 93.75% <93.75%> (ø)
...ests__/AwsClients/S3/cases/abortMultipartUpload.ts 100.00% <100.00%> (ø)
...s__/AwsClients/S3/cases/completeMultipartUpload.ts 100.00% <100.00%> (ø)
...sts__/AwsClients/S3/cases/createMultipartUpload.ts 100.00% <100.00%> (ø)
...ges/storage/__tests__/AwsClients/S3/cases/index.ts 100.00% <100.00%> (ø)
...storage/__tests__/AwsClients/S3/cases/listParts.ts 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AllanZhengYP AllanZhengYP requested a review from HuiSF June 19, 2023 19:51
@AllanZhengYP AllanZhengYP merged commit 835b74f into aws-amplify:v5/custom-clients Jun 19, 2023
kvramyasri7 pushed a commit to kvramyasri7/amplify-js that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants