feat: user agent enhancements - auth reduction #11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 6, 2023 14:52
…ain' into feat/user-agent-enhancements/auth-reduction
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## feat/user-agent-enhancements/main #11465 +/- ##
=====================================================================
- Coverage 83.37% 83.37% -0.01%
=====================================================================
Files 294 294
Lines 20804 20803 -1
Branches 4480 4480
=====================================================================
- Hits 17346 17345 -1
Misses 3171 3171
Partials 287 287
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stocaaro
reviewed
Jun 7, 2023
packages/amazon-cognito-identity-js/__tests__/UserAgent.test.js
Outdated
Show resolved
Hide resolved
stocaaro
approved these changes
Jun 7, 2023
elorzafe
reviewed
Jun 7, 2023
Comment on lines
+57
to
+90
| // SignUp = '1', | ||
| // ConfirmSignUp = '2', | ||
| // ResendSignUp = '3', | ||
| // SignIn = '4', | ||
| // GetMFAOptions = '5', | ||
| // GetPreferredMFA = '6', | ||
| // SetPreferredMFA = '7', | ||
| // DisableSMS = '8', | ||
| // EnableSMS = '9', | ||
| // SetupTOTP = '10', | ||
| // VerifyTotpToken = '11', | ||
| // ConfirmSignIn = '12', | ||
| // CompleteNewPassword = '13', | ||
| // SendCustomChallengeAnswer = '14', | ||
| // DeleteUserAttributes = '15', | ||
| // DeleteUser = '16', | ||
| // UpdateUserAttributes = '17', | ||
| // UserAttributes = '18', | ||
| // CurrentUserPoolUser = '19', | ||
| // CurrentAuthenticatedUser = '20', | ||
| // CurrentSession = '21', | ||
| // VerifyUserAttribute = '22', | ||
| // VerifyUserAttributeSubmit = '23', | ||
| // VerifyCurrentUserAttribute = '24', | ||
| // VerifyCurrentUserAttributeSubmit = '25', | ||
| // SignOut = '26', | ||
| // ChangePassword = '27', | ||
| // ForgotPassword = '28', | ||
| // ForgotPasswordSubmit = '29', | ||
| FederatedSignIn = '30', | ||
| // CurrentUserInfo = '31', | ||
| // RememberDevice = '32', | ||
| // ForgetDevice = '33', | ||
| // FetchDevices = '34', |
There was a problem hiding this comment.
Do we need these commented codes?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reduces auth user agent enhancements to send auth without the action number in amazon-cognito-identity-js per adjusted auth requirements.
Description of how you validated changes
Tested with sample app linking and unit test.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.