Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): getProperties API #11378
feat(storage): getProperties API #11378
Changes from 15 commits
7c22a1e
2d473d1
ab00587
7a6fa39
92aee69
796c11f
af5098f
2251f9b
d21c027
f7a6160
f764581
8f4572e
fdea3cc
e6c8a9f
5ad36c4
2bce874
1a3837d
cecb214
18f9e97
0ad6dec
eea6590
68cd516
405e8f8
8449227
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
prov
can be made more descriptive? Also there seems to be a util function to get the provider.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this API should support SSE to align with the other APIs (
HeadObject
command supports it it looks like). It would be strange if you can upload/download SSE-enabled objects but can't get the meta-data for them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added SSE support!