feat(data): refactor single-client consecutive update unit tests; fake GraphQL service updates #11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-mcafee
force-pushed
the
ds-single-client-consistency-test-updates
branch
2 times, most recently
from
ee70a6c to
b03905b
Compare
david-mcafee
changed the title
david-mcafee
force-pushed
the
ds-single-client-consistency-test-updates
branch
from
b03905b to
63a806c
Compare
…ingle-client consecutive update consistency unit tests; update fake GraphQL service to accept latency overrides for individual requests; create utils for performing consecutive updates and making common assertions; refactor existing tests to use new helpers
david-mcafee
force-pushed
the
ds-single-client-consistency-test-updates
branch
from
63a806c to
9f7e6d1
Compare
david-mcafee
changed the title
david-mcafee
added
Testing
DataStore
david-mcafee
commented
May 6, 2023
svidgen
reviewed
May 9, 2023
Co-authored-by: Jon Wire <iambipedal@gmail.com>
|
I forgot to mention: This PR title is pretty big. It's not written in our contributing guide, but I think we should generally follow the 50-ish character title limit, so the titles aren't truncated in a |
david-mcafee
changed the title
Updated! |
svidgen
approved these changes
May 10, 2023
dpilch
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
feat(data): add assertions to test queried versions for DataStore's single-client consecutive update consistency unit tests; update fake GraphQL service to accept latency overrides for individual requests; create utils for performing consecutive updates and making common assertions; refactor existing tests to use new helpers
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.