Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Snyk security scanning #11285

Merged
merged 13 commits into from
May 8, 2023
Merged

feat: Add Snyk security scanning #11285

merged 13 commits into from
May 8, 2023

Conversation

stocaaro
Copy link
Member

@stocaaro stocaaro commented Apr 21, 2023

Description of changes

Add Snyk based scanning to the amplify-js repository.

This will run on the org repository, but the scan will be skipped on forks to avoid error messages related to configuration and secrets.

Description of how you validated changes

This change has been tested on my fork of the repository with different triggering and gating values (see commit history).

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro marked this pull request as ready for review May 5, 2023 17:01
@stocaaro stocaaro requested a review from a team as a code owner May 5, 2023 17:01
jimblanc
jimblanc previously approved these changes May 5, 2023
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

AllanZhengYP
AllanZhengYP previously approved these changes May 5, 2023
cshfang
cshfang previously approved these changes May 5, 2023
@stocaaro stocaaro dismissed stale reviews from cshfang, AllanZhengYP, and jimblanc via aa2fd5b May 5, 2023 18:37
@stocaaro stocaaro merged commit 06dae62 into aws-amplify:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants