fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update fake GraphQL service to extract singular name of model when parsing queries, and update broken RegEx; update connectivity handling unit test to fail on all errors #11261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
While working on connectivity handling unit tests, I discovered errors in the Sync Processor's jittered retry function that were being lost. When I surfaced the error, I then discovered that the fake GraphQL service's
parseQuery
function had a broken RegEx (would not match, for instance,syncCompositePKChildren
), and was not matching singular table names when parsing queries. I fixed the RegEx, and added a util for extracting singular table names. Additionally, I updated the unit test to fail on all errors, not a filtered subset (i.e. it should now fail when jittered retry fails).Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.