Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update fake GraphQL service to extract singular name of model when parsing queries, and update broken RegEx; update connectivity handling unit test to fail on all errors #11261

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

david-mcafee
Copy link
Contributor

@david-mcafee david-mcafee commented Apr 17, 2023

Description of changes

While working on connectivity handling unit tests, I discovered errors in the Sync Processor's jittered retry function that were being lost. When I surfaced the error, I then discovered that the fake GraphQL service's parseQuery function had a broken RegEx (would not match, for instance, syncCompositePKChildren), and was not matching singular table names when parsing queries. I fixed the RegEx, and added a util for extracting singular table names. Additionally, I updated the unit test to fail on all errors, not a filtered subset (i.e. it should now fail when jittered retry fails).

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… Update sync processor to log errors on retry; update broken fake GraphQL service RegEx; update connectivity handling unit test to fail on all errors
@david-mcafee david-mcafee requested a review from a team as a code owner April 17, 2023 17:21
@david-mcafee david-mcafee changed the title fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update broken fake GraphQL service RegEx; update connectivity handling unit test to fail on all errors fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update broken fake GraphQL service RegEx; update fake GraphQL service to extract singular name of model when parsing queries; update connectivity handling unit test to fail on all errors Apr 17, 2023
@david-mcafee david-mcafee changed the title fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update broken fake GraphQL service RegEx; update fake GraphQL service to extract singular name of model when parsing queries; update connectivity handling unit test to fail on all errors fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update fake GraphQL service to extract singular name of model when parsing queries, and update broken RegEx; ; update connectivity handling unit test to fail on all errors Apr 17, 2023
@david-mcafee david-mcafee changed the title fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update fake GraphQL service to extract singular name of model when parsing queries, and update broken RegEx; ; update connectivity handling unit test to fail on all errors fix(data): sync processor, fake GraphQL service, and unit test fixes. Update sync processor to log errors on retry; update fake GraphQL service to extract singular name of model when parsing queries, and update broken RegEx; update connectivity handling unit test to fail on all errors Apr 17, 2023
@david-mcafee david-mcafee requested a review from a team as a code owner April 17, 2023 19:22
svidgen
svidgen previously approved these changes Apr 17, 2023
dpilch
dpilch previously approved these changes Apr 17, 2023
@david-mcafee david-mcafee requested a review from a team April 17, 2023 19:35
@david-mcafee david-mcafee dismissed stale reviews from dpilch and svidgen via 6b61578 April 17, 2023 19:36
@david-mcafee david-mcafee requested a review from a team April 17, 2023 19:37
@david-mcafee david-mcafee merged commit 992b7eb into main Apr 17, 2023
@david-mcafee david-mcafee deleted the 04-17-fixes branch April 17, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants