fix(notifications): Fix permissions type #11237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elorzafe
previously approved these changes
Apr 12, 2023
thaddmt
previously approved these changes
Apr 12, 2023
jimblanc
previously approved these changes
Apr 12, 2023
stocaaro
previously approved these changes
Apr 12, 2023
cshfang
force-pushed
the
fix/fix-permissions-type
branch
from
ce9cf4e to
9402430
Compare
elorzafe
previously approved these changes
Apr 12, 2023
jimblanc
previously approved these changes
Apr 12, 2023
cshfang
force-pushed
the
fix/fix-permissions-type
branch
from
9402430 to
fb321b9
Compare
jimblanc
approved these changes
Apr 12, 2023
haverchuck
approved these changes
Apr 12, 2023
elorzafe
approved these changes
Apr 12, 2023
thaddmt
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes an issue with typing on the PN Permission request
Description of how you validated changes
yarn buildlocally and see that the*.d.tsfile is now cleanChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.