Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lerna config to fix build #11235

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix: update lerna config to fix build #11235

merged 2 commits into from
Apr 12, 2023

Conversation

david-mcafee
Copy link
Contributor

@david-mcafee david-mcafee commented Apr 12, 2023

Description of changes

After the recent Lerna upgrade, builds are failing for Intel Macs. Nx is a task scheduler that ships with Lerna by default - setting it's usage to false fixes builds for Intel Macs, and continues to work as expected for M1 Macs.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee requested a review from a team as a code owner April 12, 2023 20:53
@david-mcafee david-mcafee requested a review from a team April 12, 2023 20:55
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@david-mcafee david-mcafee merged commit 26d142b into main Apr 12, 2023
@david-mcafee david-mcafee deleted the lerna-config-fix branch April 12, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants