fix: Codescanning alerts #11159
Merged
fix: Codescanning alerts #11159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
approved these changes
Mar 30, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #11159 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 204 204
Lines 19514 19514
Branches 4216 4216
=======================================
Hits 16077 16077
Misses 3151 3151
Partials 286 286
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jimblanc
approved these changes
Mar 30, 2023
| @@ -100,5 +100,26 @@ describe('I18n test', () => { | |||
| cn: {}, | |||
| }; | |||
| }); | |||
|
|
|||
| test('multi-call putVocabulariesForLanguage results in correct get result', () => { | |||
| @@ -87,7 +87,7 @@ | |||
| "name": "Core (I18n)", | |||
| "path": "./lib-esm/index.js", | |||
| "import": "{ I18n }", | |||
| "limit": "2 kB" | |||
| "limit": "2.1 kB" | |||
There was a problem hiding this comment.
Wonder why this went up for such a small change?
cshfang
pushed a commit
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes (I expect) for the errors in the Amplify JS security tab.
Description of how you validated changes
I manually validated that the regex continues to match for a signed s3 url.
The I18N testing didn't seem complete enough so I added a test which I confirmed passes before and after my change (but doesn't pass if I replace the object instead of merging it into the existing object).
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.