Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(notifications): Add native Android unit tests #11139

Merged
merged 2 commits into from
Mar 28, 2023
Merged

test(notifications): Add native Android unit tests #11139

merged 2 commits into from
Mar 28, 2023

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Mar 27, 2023

Description of changes

This PR adds Android unit tests for the Push Notification native module

Issue #, if available

Description of how you validated changes

Updated test script in native module package. Validated yarn test passes. Validated local sample app still working as intended.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang requested a review from a team as a code owner March 27, 2023 18:48
@codecov-commenter
Copy link

Codecov Report

Merging #11139 (d55e353) into push-notification/main (5f8702e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                   @@
##           push-notification/main   #11139   +/-   ##
=======================================================
  Coverage                   82.64%   82.64%           
=======================================================
  Files                         211      211           
  Lines                       19941    19941           
  Branches                     4332     4332           
=======================================================
  Hits                        16480    16480           
  Misses                       3172     3172           
  Partials                      289      289

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AllanZhengYP
AllanZhengYP approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the test cases only, they look good to me.

@cshfang cshfang merged commit 73eda14 into aws-amplify:push-notification/main Mar 28, 2023
@cshfang cshfang deleted the push-notification/add-android-unit-tests branch March 28, 2023 19:02
cshfang added a commit to cshfang/amplify-js that referenced this pull request Mar 28, 2023
@cshfang @AllanZhengYP
@iartemiev @jimblanc @dependabot @svidgen @dpilch @david-mcafee @helgabalashova @stocaaro
Push notification/main (#8)
2c166ea 
* feat(cognito): remove required domain param when create CookieStorage

* test: enable integ test

* test(cognito): update unit test

* Revert "test: enable integ test"

This reverts commit e3db965.

* feat(cognito): make cookiestorage constructor parameter optional

* chore: Docs updates (aws-amplify#11082)

* chore(release): Publish [ci skip]

 - @aws-amplify/analytics@6.0.19
 - @aws-amplify/api-graphql@3.1.7
 - @aws-amplify/api-rest@3.0.19
 - @aws-amplify/api@5.0.19
 - @aws-amplify/auth@5.1.13
 - aws-amplify@5.0.19
 - @aws-amplify/cache@5.0.19
 - @aws-amplify/core@5.1.2
 - @aws-amplify/datastore-storage-adapter@2.0.19
 - @aws-amplify/datastore@4.1.1
 - @aws-amplify/geo@2.0.19
 - @aws-amplify/interactions@5.0.19
 - @aws-amplify/notifications@1.0.19
 - @aws-amplify/predictions@5.0.19
 - @aws-amplify/pubsub@5.1.2
 - @aws-amplify/pushnotification@5.0.19
 - @aws-amplify/storage@5.1.9
 - @aws-amplify/xr@4.0.19

* chore(release): update version.ts [ci skip]

* refactor(datastore): storage adapters (aws-amplify#11073)

* chore: Docs updates (aws-amplify#11091)

* chore: Tweaked `main` pre-id. (aws-amplify#11093)

* chore(deps): bump activesupport from 6.1.7.2 to 7.0.4.3 in /docs

Bumps [activesupport](https://github.com/rails/rails) from 6.1.7.2 to 7.0.4.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.3/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v6.1.7.2...v7.0.4.3)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(release): Publish [ci skip]

 - @aws-amplify/analytics@6.0.20
 - @aws-amplify/api-graphql@3.1.8
 - @aws-amplify/api-rest@3.0.20
 - @aws-amplify/api@5.0.20
 - @aws-amplify/auth@5.1.14
 - aws-amplify@5.0.20
 - @aws-amplify/cache@5.0.20
 - @aws-amplify/core@5.1.3
 - @aws-amplify/datastore-storage-adapter@2.0.20
 - @aws-amplify/datastore@4.1.2
 - @aws-amplify/geo@2.0.20
 - @aws-amplify/interactions@5.0.20
 - @aws-amplify/notifications@1.0.20
 - @aws-amplify/predictions@5.0.20
 - @aws-amplify/pubsub@5.1.3
 - @aws-amplify/pushnotification@5.0.20
 - @aws-amplify/storage@5.1.10
 - @aws-amplify/xr@4.0.20

* chore(release): update version.ts [ci skip]

* chore(@aws-amplify/datastore): initial decomposition of test helpers (aws-amplify#11096)

* moved test helpers to folder

* first pass, rough decomposition of test helpers file

* added readme for helpers

* test helpers readme typo

* Update packages/datastore/__tests__/helpers/README.md

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>

---------

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>

* fix: add warning message when trying to use SQLite with CPK enabled (aws-amplify#11027)

* fix(data): update SQLite utils to use 'instr' instead of 'like' when constructing WHERE conditions from predicates (aws-amplify#11108)

* chore: Docs updates (aws-amplify#11111)

* docs(cognito): excluding subdomains when domain cookie attr is omitted

* chore(release): Publish [ci skip]

 - @aws-amplify/analytics@6.0.21
 - @aws-amplify/api-graphql@3.1.9
 - @aws-amplify/api-rest@3.0.21
 - @aws-amplify/api@5.0.21
 - @aws-amplify/auth@5.1.15
 - aws-amplify@5.0.21
 - @aws-amplify/cache@5.0.21
 - @aws-amplify/core@5.1.4
 - @aws-amplify/datastore-storage-adapter@2.0.21
 - @aws-amplify/datastore@4.1.3
 - @aws-amplify/geo@2.0.21
 - @aws-amplify/interactions@5.0.21
 - @aws-amplify/notifications@1.0.21
 - @aws-amplify/predictions@5.0.21
 - @aws-amplify/pubsub@5.1.4
 - @aws-amplify/pushnotification@5.0.21
 - @aws-amplify/storage@5.1.11
 - @aws-amplify/xr@4.0.21

* chore(release): update version.ts [ci skip]

* test: increase coverage for delete connection by model field (aws-amplify#11099)

* Update config.yml

Removes `Usage Question` link that sends users to an old 404 page for discussions

* fix(datastore): stale observeQuery snapshot with sort param (aws-amplify#11119)

* chore(notifications): Integrate refactored Android common utils

* chore: Docs updates

* Update config.yml

Switched usage question to point at discord rather than deleting it

* chore(release): Publish [ci skip]

 - amazon-cognito-identity-js@6.2.0
 - @aws-amplify/analytics@6.0.22
 - @aws-amplify/api-graphql@3.1.10
 - @aws-amplify/api-rest@3.0.22
 - @aws-amplify/api@5.0.22
 - @aws-amplify/auth@5.2.0
 - aws-amplify@5.0.22
 - @aws-amplify/cache@5.0.22
 - @aws-amplify/core@5.1.5
 - @aws-amplify/datastore-storage-adapter@2.0.22
 - @aws-amplify/datastore@4.1.4
 - @aws-amplify/geo@2.0.22
 - @aws-amplify/interactions@5.0.22
 - @aws-amplify/notifications@1.0.22
 - @aws-amplify/predictions@5.0.22
 - @aws-amplify/pubsub@5.1.5
 - @aws-amplify/pushnotification@5.0.22
 - @aws-amplify/storage@5.1.12
 - @aws-amplify/xr@4.0.22

* chore(release): update version.ts [ci skip]

* fix(@aws-amplify/datastore): mutation hub event drops during reconnect (aws-amplify#11132)

* fix(@aws-amplify/datastore): fixes mutation hub event dropped during races with reconnect

* add explicit observer completion, expanded test coverage

* fix(@aws-amplify/datastore): adds serialization for empty predicates (aws-amplify#11133)

adds serialization for empty predicates

* test(notifications): Add native Android unit tests (aws-amplify#11139)

* test(notifications): Add native Android unit tests

* Disable android tests from being automatically run in CI

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Allan Zheng <zheallan@amazon.com>
Co-authored-by: aws-amplify-bot <aws@amazon.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jon Wire <iambipedal@gmail.com>
Co-authored-by: Dane Pilcher <dppilche@amazon.com>
Co-authored-by: David McAfee <mcafd@amazon.com>
Co-authored-by: Olya Balashova <42189299+helgabalashova@users.noreply.github.com>
Co-authored-by: Bannon Tanner <bannonta@amazon.com>
Co-authored-by: helgabalashova <helga.stolyarova@gmail.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblanc jimblanc jimblanc approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cshfang @codecov-commenter @jimblanc @AllanZhengYP