Remove unnecessary error.log #11084
Merged
Remove unnecessary error.log #11084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error log creates noise when developing. Specifically in react-native you get an error box overlayed on the app. The library is already throwing an error, so upstream code has to deal with it, there isn't any value in logging at error level.
jimblanc
approved these changes
Apr 7, 2023
helgabalashova
approved these changes
Apr 7, 2023
|
Thank you for your contribution! I went ahead and merged your change. |
cshfang
pushed a commit
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The error log creates noise when developing. Specifically, in react-native you get an error box overlayed on the app. The library is already throwing an error, so upstream code has to deal with it, there isn't any value in logging at error level.
Issue #, if available
N/A
Description of how you validated changes
N/A - Trivial change.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.