Update push notification to support Android SDK 31+ #10914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
changed the title
jimblanc
approved these changes
Jan 31, 2023
| @@ -78,7 +81,7 @@ private PendingIntent toScheduleNotificationIntent(Bundle bundle) { | |||
| notificationIntent.putExtra(RNPushNotificationPublisher.NOTIFICATION_ID, notificationID); | |||
| notificationIntent.putExtras(bundle); | |||
|
|
|||
| return PendingIntent.getBroadcast(context, notificationID, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT); | |||
| return PendingIntent.getBroadcast(context, notificationID, notificationIntent, getPendingIntentFlags()); | |||
There was a problem hiding this comment.
Should this be getActivity?
There was a problem hiding this comment.
I did not update these as our library does not support scheduled notifications at this time despite including this underlying native code
| @@ -353,16 +353,11 @@ public void sendToNotificationCentre(Bundle bundle) { | |||
| // Add "action" for later identifying which button gets pressed. | |||
| bundle.putString("action", action); | |||
| actionIntent.putExtra("notification", bundle); | |||
| PendingIntent pendingActionIntent = PendingIntent.getBroadcast(context, notificationID, actionIntent, | |||
| PendingIntent.FLAG_UPDATE_CURRENT); | |||
| PendingIntent pendingActionIntent = PendingIntent.getBroadcast(context, notificationID, actionIntent, getPendingIntentFlags()); | |||
There was a problem hiding this comment.
Should this be getActivity too?
There was a problem hiding this comment.
Ditto here in that we don't really support actions ootb
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Android 12 included two behavior changes which affected Amplify push notification:
PendingIntents now require mutability flag to be specifiedThis PR updates Amplify push notification to address these two behavioral changes:
PendingIntentsnow include mutability flag (set to immutable)This PR also cleans up the state of the Android artifacts checked into this repo to remove the
.gradle/folder but include the gradle wrapper.Issue #, if available
#10118May not actually be relevant#10252
Description of how you validated changes
Tested locally with sample Android apps targeting < SDK 31 and >= SDK 31
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.