chore: inc idb time clamps in tests due to CI slowness #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iartemiev
approved these changes
Jan 18, 2023
dpilch
approved these changes
Jan 18, 2023
jimblanc
approved these changes
Jan 18, 2023
david-mcafee
approved these changes
Jan 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #10879 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 198 198
Lines 19584 19584
Branches 4227 4227
=======================================
Hits 15975 15975
Misses 3318 3318
Partials 291 291 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
This was referenced Aug 8, 2023
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some IndexedDB time limit clamps were too aggressive for the CI execution environment. I had hesitations about including some of these as straight-up time limits. I favored this for some of the scenarios to keep test times down -- the alternative was to run scenarios twice on different schemas to demonstrate an increase in performance due to index usage.
For now, I'm bumping the time limits up for the CI execution environment.
Issue #, if available
Description of how you validated changes
Re-ran the tests. We'll have to see whether integ tests pass. If they don't, I'll temporarily disable the tests until I can rewrite them as comparative tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.