Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Flip all deprecated UI packages back to private to resolve deployment issues. #10602

Merged
merged 17 commits into from
Nov 3, 2022

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Nov 3, 2022

Description of changes

This changes flips all deprecated UI packages back to private to resolve some deployment issues we're seeing onmain.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review November 3, 2022 16:02
@jimblanc jimblanc requested review from a team as code owners November 3, 2022 16:02
stocaaro
stocaaro previously approved these changes Nov 3, 2022
elorzafe
elorzafe previously approved these changes Nov 3, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks @jimblanc 🔥

@codecov-commenter
Copy link

Codecov Report

Merging #10602 (83b9489) into main (ec59a62) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #10602      +/-   ##
==========================================
- Coverage   84.91%   84.57%   -0.34%     
==========================================
  Files         260      182      -78     
  Lines       19771    16720    -3051     
  Branches     4240     3518     -722     
==========================================
- Hits        16788    14141    -2647     
+ Misses       2892     2500     -392     
+ Partials       91       79      -12     
Impacted Files Coverage Δ
...ges/aws-amplify-react/src/Widget/SelectMFAType.tsx
...kages/aws-amplify-react/src/Auth/VerifyContact.tsx
packages/aws-amplify-react/src/XR/IconButton.tsx
...plify-react/src/Auth/common/country-dial-codes.tsx
...ckages/aws-amplify-react/src/AmplifyMessageMap.tsx
...ages/aws-amplify-vue/src/events/AmplifyEventBus.js
.../aws-amplify-react/src/Auth/Provider/withAuth0.tsx
packages/aws-amplify-react/src/Storage/S3Album.tsx
packages/aws-amplify-react/src/Storage/Common.tsx
...amplify-vue/src/components/authenticator/common.js
... and 68 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants