chore: remove sideeffects mark on non-code artifacts #10578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dcc2629.
Codecov Report
@@ Coverage Diff @@
## next-major-version/5 #10578 +/- ##
=====================================================
Coverage 85.43% 85.43%
=====================================================
Files 197 197
Lines 18179 18179
Branches 3869 3869
=====================================================
Hits 15532 15532
Misses 2566 2566
Partials 81 81 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jimblanc
approved these changes
Nov 1, 2022
cshfang
approved these changes
Nov 1, 2022
stocaaro
added a commit
to stocaaro/amplify-js
that referenced
this pull request
Nov 1, 2022
commit bc989eb Author: AllanZhengYP <zheallan@amazon.com> Date: Tue Nov 1 15:21:01 2022 -0700 chore: use --ignore-engines option in CI (aws-amplify#10589) commit c534a50 Author: Francisco Rodriguez <frodriguez.cs@gmail.com> Date: Tue Nov 1 12:27:18 2022 -0700 Removing deprecated PubSub provider type (aws-amplify#10585) commit ec82d5c Merge: a56ee24 c5f7732 Author: AllanZhengYP <zheallan@amazon.com> Date: Tue Nov 1 10:16:51 2022 -0700 chore: remove sideeffects mark on non-code artifacts (aws-amplify#10578) commit c5f7732 Author: Allan Zheng <zheallan@amazon.com> Date: Tue Nov 1 09:23:59 2022 -0700 Revert "test: enable integ tests on clean-sideeffects branch" This reverts commit dcc2629. commit dcc2629 Author: Allan Zheng <zheallan@amazon.com> Date: Tue Oct 25 12:31:49 2022 -0700 test: enable integ tests on clean-sideeffects branch commit c3bae45 Author: Allan Zheng <zheallan@amazon.com> Date: Tue Oct 25 12:30:08 2022 -0700 chore: clean the sideEffects on source and dist files
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
distfolder, the folder can be removed fromsideEffectslist ofpackage.json.srcfolder doesn't contain the JS code to be bundled, they can also be removed fromsideEffectslist.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.