chore: Move cache sideEffects to align with other packages
#10562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next-major-version/5 #10562 +/- ##
========================================================
+ Coverage 84.65% 84.67% +0.01%
========================================================
Files 195 195
Lines 17439 17438 -1
Branches 3693 3693
========================================================
+ Hits 14763 14765 +2
+ Misses 2597 2594 -3
Partials 79 79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cshfang
reviewed
Oct 28, 2022
|
|
||
| /** Always importing Auth when users import Amplify such that | ||
| for unauthenticated access (no sign in and sign up), | ||
| users don't have to import Auth explicitly **/ | ||
| Amplify.Auth = Auth; | ||
| Amplify.Cache = Cache; |
There was a problem hiding this comment.
Is this technically a breaking change if someone were accessing the Cache via the singleton?
There was a problem hiding this comment.
Just making sure we call out this breaking change in v5 changelog
There was a problem hiding this comment.
Yep it would be, it'll have to go into the changelog (this usage pattern has been deprecated for a while I believe).
Comment on lines
+4
to
+5
| import { Amplify, ConsoleLogger as Logger } from '@aws-amplify/core'; | ||
| import AsyncStorage from '@react-native-async-storage/async-storage'; |
cshfang
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change moves the side effects in
cacheout ofindex.ts(andreactnative.ts) to align with the other categories. It also removescacheas a default static member (currently unused) of the Amplify singleton in order to reduce bundle size for use cases that don't directly usecache. Finally, it removescacheas a dependency ofauth.Observed bundle size improvements in a barebones CRA app:
Parsed: -15.1 kB
GZipped: -2.06 kB
Issue #, if available
Description of how you validated changes
Local testing.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.