Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Short: This fixes refactors imports to remove all potential for import cycles
Long: Vite uses a different build process that is more sensitive to dependency cycles. In this case, I'm relatively confident that the problem was introduced with how the
ConnectionState
enum was accessed inConnectionStateMonitor.ts
, however having failed to root out all of the issues once, I've gone through to change the import structure to ensure that there are no import cycles in the package.Issue #, if available
#10287
#10341
Description of how you validated changes
I have reproduction apps with both React and Vue. For both, I verified the issue before:
rm -rf node_modules/.vite/deps && yarn dev
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.