feat(logging): add LoggingConfig to AmplifyConfig #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikaHsn
force-pushed
the
feat/logging/config
branch
from
0335f98 to
386f8fc
Compare
khatruong2009
approved these changes
Sep 21, 2023
dnys1
approved these changes
Sep 25, 2023
Comment on lines
281
to
282
| defaultLogLevel = LogLevel.values | ||
| .byName(loggingConstraint.defaultLogLevel.toLowerCase()); |
There was a problem hiding this comment.
Nah I would throw here - we shouldn't accept invalid configurations. Users may have had a typo or something silly.
There was a problem hiding this comment.
Throw a ConfigurationError type
There was a problem hiding this comment.
updated the logging config to use enum instead of string. so if the config file is not valid it throws at the configuration.
khatruong2009
pushed a commit
that referenced
this pull request
Nov 27, 2023
* feat(logging): add LoggingConfig to AmplifyConfig * chore(logging): cloudwatch logger plugin to use amplify_core logging config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.