Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: top level prop available as variables #62

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix: top level prop available as variables #62

merged 1 commit into from
Sep 10, 2021

Conversation

frimfram
Copy link
Contributor

@frimfram frimfram commented Sep 10, 2021

Issue #, if available: 60

Description of changes:

Added bindingProperty variable statements inside component function wrapper.

Before

export type ListingCardProps = {
  title: String
} & {
  overrides?: EscapeHatchProps | undefined | null
};
export default function ListingCard(props: ListingCardProps): JSX.Element {
  return (
    <Flex

After

export type ListingCardProps = {
  title?: String
} & {
  overrides?: EscapeHatchProps | undefined | null
};
export default function ListingCard(props: ListingCardProps): JSX.Element {
  const { tiitle } = props;

  return (
    <Flex

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@frimfram frimfram linked an issue Sep 10, 2021 that may be closed by this pull request
@frimfram frimfram merged commit 788802e into main Sep 10, 2021
@frimfram frimfram deleted the issue-60-fix branch September 10, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top level props need to be available to render function
2 participants