feat: add base action binding support #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dpilch
commented
Oct 12, 2021
dpilch
commented
- Base action binding support.
- Use stub function to map generic event name to React event name.
- The fully functional version will be in amplify-ui
- Does not support property binding for action parameters yet
- need golden file
- will be implemented in separate PR
alharris-at
previously approved these changes
Oct 13, 2021
packages/studio-ui-codegen-react/lib/react-component-render-helper.ts
Outdated
Show resolved
Hide resolved
alharris-at
dismissed
their stale review
Meant to leave the comment on throwing without an approval.
dpilch
force-pushed
the
signout-action
branch
from
694e8fa
to
b025d95
Compare
alharris-at
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.