Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example, don't merge #1167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Example, don't merge #1167

wants to merge 1 commit into from

Conversation

cwoolum
Copy link
Contributor

@cwoolum cwoolum commented Sep 17, 2024

Problem

Solution

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cwoolum cwoolum requested a review from a team as a code owner September 17, 2024 16:47
">0.2%",
"not dead",
"not op_mini all"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Legacy Javascript lighthouse violation. This project uses CRA which takes advantage of browserslist for removing legacy code. By adding a stricter config, only code supporting the defined browsers will be included in your bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant