Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Cypress dependency #1163

Merged
merged 1 commit into from
Jun 25, 2024
Merged

chore: update Cypress dependency #1163

merged 1 commit into from
Jun 25, 2024

Conversation

awinberg-aws
Copy link
Contributor

@awinberg-aws awinberg-aws commented Jun 25, 2024

Problem

CI runs were consistently failing due to a change in the @cypress/code-coverage package adding an optional chain for null safety, but results in a Module parse failed: Unexpected token error.

cypress-io/code-coverage#822

Solution

Updating to a more recent version of Cypress resolves the module parse error as it likely enables compatibility for optional chaining.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - no functional change
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (c044fb9) to head (55f08bc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         150      150           
  Lines        6114     6114           
  Branches     1838     1838           
=======================================
  Hits         5739     5739           
  Misses        357      357           
  Partials       18       18           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c044fb9...55f08bc. Read the comment docs.

@awinberg-aws awinberg-aws changed the title chore: throwaway test to verify CI health chore: update Cypress dependency Jun 25, 2024
@awinberg-aws awinberg-aws marked this pull request as ready for review June 25, 2024 20:15
@awinberg-aws awinberg-aws requested a review from a team as a code owner June 25, 2024 20:15
Copy link
Contributor

@cwoolum cwoolum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awinberg-aws awinberg-aws merged commit cbcdf8f into main Jun 25, 2024
11 checks passed
@awinberg-aws awinberg-aws deleted the test-update branch June 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants