Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate useAuth hook for v6 #1137

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix: migrate useAuth hook for v6 #1137

merged 2 commits into from
Nov 22, 2023

Conversation

letsbelopez
Copy link
Contributor

Problem

We need to migrate the useAuth hook for v6

Solution

Migrate it over

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner November 22, 2023 00:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Merging #1137 (8a82f39) into main (69ece2f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   93.85%   93.86%           
=======================================
  Files         149      150    +1     
  Lines        6104     6112    +8     
  Branches     1834     1836    +2     
=======================================
+ Hits         5729     5737    +8     
  Misses        357      357           
  Partials       18       18           
Files Coverage Δ
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <100.00%> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 93.65% <100.00%> (+0.03%) ⬆️
...-react/lib/react-utils-studio-template-renderer.ts 96.07% <100.00%> (+0.16%) ⬆️
...n-ui-react/lib/utils-file-functions/hooks/index.ts 100.00% <100.00%> (ø)
...ui-react/lib/utils-file-functions/hooks/useAuth.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ece2f...8a82f39. Read the comment docs.

@letsbelopez letsbelopez merged commit 0ebdca2 into main Nov 22, 2023
10 checks passed
@letsbelopez letsbelopez deleted the useAuthHookMigration branch November 22, 2023 01:08
letsbelopez added a commit that referenced this pull request Nov 27, 2023
* fix: migrate useAuth hook for v6

* fix: remove console log

---------

Co-authored-by: David Lopez <lopezbnd@amazon.com>
letsbelopez added a commit that referenced this pull request Nov 29, 2023
* fix: init v6 integ tests

* fix: migrate useAuth hook for v6 (#1137)

* fix: migrate useAuth hook for v6

* fix: remove console log

---------

Co-authored-by: David Lopez <lopezbnd@amazon.com>

* fix: v6 broken integ tests

* chore: put v5 and v6 test templates in separate packages

* fix: pin ts to 4.4.4 for integ tests

* fix: add no-ci flag to integ v6

* fix: import Amplify

* fix: add mock exports

* fix: update templates back to test-generator package

* fix: remove new integ test packages

* fix: menu test

* fix: rename v5 test template

* fix: v5 integ tests remove view and tabs primitive

---------

Co-authored-by: David Lopez <lopezbnd@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants